replace tanArc(to) with tanArcToRelative #3729
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3319
Adding a
relative: bool
parameter totangentialArcTo
proved to be very complicated (see PR). The Rust changes were simple, but the Typescript code has deeply-held assumptions that stdlib sketch functions have 2 mandatory variables (a point, then a sketchgroup) and one optional tag. Breaking this assumption involved a lot of changes that complicated the code. It also made me realize that there's probably value in keeping the stdlib sketch functions similar, i.e. they all have the same type signature. I think this will result in fewer surprises for users.